-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PB-5815: clean image secrets during data export and resource export cleanup. #345
Conversation
OSS Scan Results:
Total issues: 47 |
License Evaluation Results:
Total License Issues: 19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can we check this with the test cases which validates total resource count
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JFYI please remember to cherry-pick this commit to kdmp release branch(1.2.11 guess) and vendor to release-24.1.0 stork branch.
RCA
After taking a nfs volume backup and resource backup we were not cleaning up the image-secret-jobname
causing increase in the resource count in the next backups.
Solution implemented
dataExportCR reconciler cleanup should be updated to delete the secret even if the transferID is present
resourceExportCR reconciler cleanup should be updated to delete the secret if the transferID is present.
What this PR does / why we need it:
To clean the image secret resource during cleanup of data export and resource export resources
Which issue(s) this PR fixes (optional)
Closes #PB-5815
Special notes for your reviewer: